Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a "flag" filter to registry #5328

Merged
merged 7 commits into from
Nov 11, 2024
Merged

Conversation

taylorhelene
Copy link
Contributor

I have added a flag button on the search that adds flags like 'deprecated', 'native' and 'first party'. I have changed these thee components:

  • assets/js/registrySearch.js
  • layouts/partials/ecosystem/registry/entry.html
  • layouts/shortcodes/ecosystem/registry/search-form.html

flags

deprecated

@taylorhelene taylorhelene requested a review from a team as a code owner October 5, 2024 08:15
Copy link

linux-foundation-easycla bot commented Oct 5, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@opentelemetrybot opentelemetrybot requested review from a team and mx-psi and removed request for a team October 7, 2024 08:02
@svrnm svrnm changed the title Added flag button to registry [outreachy] Added flag button to registry Oct 7, 2024
@svrnm svrnm added outreachy Issues for Outreachy Participants and removed lang:es labels Oct 7, 2024
@svrnm
Copy link
Member

svrnm commented Oct 7, 2024

thanks, this looks really good already. Note that selecting the "first party" flag doesn't work, can you take another look?

@taylorhelene
Copy link
Contributor Author

It works when removing spaces from the "first party" flag

@taylorhelene
Copy link
Contributor Author

I have added "first_party" then removed the console logs and prints I had added.

Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall, some minor change requests.

assets/js/registrySearch.js Outdated Show resolved Hide resolved
assets/js/registrySearch.js Outdated Show resolved Hide resolved
assets/js/registrySearch.js Outdated Show resolved Hide resolved
assets/js/registrySearch.js Outdated Show resolved Hide resolved
assets/js/registrySearch.js Outdated Show resolved Hide resolved
layouts/shortcodes/ecosystem/registry/search-form.html Outdated Show resolved Hide resolved
@svrnm svrnm removed the request for review from mx-psi October 8, 2024 13:02
@svrnm
Copy link
Member

svrnm commented Oct 10, 2024

lgtm overall, can you do the following please to fix the remaining CI issues:

  • update your branch with the latest commit to main
  • run npm run fix:all locally and commit the changes.

@taylorhelene
Copy link
Contributor Author

Do I sync my fork with the latest commits from main or do I push to origin main. I do not understand the first suggestion of updating branch with the latest commit to main.

@svrnm
Copy link
Member

svrnm commented Oct 11, 2024

Do I sync my fork with the latest commits from main or do I push to origin main. I do not understand the first suggestion of updating branch with the latest commit to main.

You sync your fork with the latest commit from main, you have done that successfully already what I can see 👍

@svrnm svrnm changed the title [outreachy] Added flag button to registry ✅ [outreachy] Added flag button to registry Oct 11, 2024
@svrnm
Copy link
Member

svrnm commented Oct 11, 2024

Thank you @taylorhelene! This looks really good, I consider this as done! After the outreachy application phase we will take another look and see if we can merge this PR.

@taylorhelene
Copy link
Contributor Author

Okay then. Thank you for the directions given.

@svrnm svrnm linked an issue Nov 6, 2024 that may be closed by this pull request
@svrnm svrnm changed the title ✅ [outreachy] Added flag button to registry add a "flag" filter to registry Nov 6, 2024
@opentelemetrybot opentelemetrybot requested review from a team and mx-psi and removed request for a team November 11, 2024 13:24
@opentelemetrybot opentelemetrybot requested a review from a team November 11, 2024 13:25
@svrnm svrnm added registry and removed lang:es outreachy Issues for Outreachy Participants labels Nov 11, 2024
@svrnm svrnm removed request for mx-psi and a team November 11, 2024 14:24
@svrnm svrnm added this pull request to the merge queue Nov 11, 2024
@svrnm
Copy link
Member

svrnm commented Nov 11, 2024

Thank you once again @taylorhelene !

Merged via the queue into open-telemetry:main with commit 43fa411 Nov 11, 2024
17 checks passed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this PR deleting an es page?

/cc @svrnm @theletterf

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow. I missed that. Huge apologies!!

@chalin
Copy link
Contributor

chalin commented Nov 11, 2024

Also, note the following bug. I'm not sure if it was introduced by this PR or not:

drewby pushed a commit to drewby/opentelemetry.io that referenced this pull request Nov 21, 2024
drewby pushed a commit to drewby/opentelemetry.io that referenced this pull request Dec 5, 2024
ymotongpoo pushed a commit to ymotongpoo/opentelemetry.io that referenced this pull request Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add a filter to the registry for "is native" and "is first party"
3 participants