-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a "flag" filter to registry #5328
Conversation
thanks, this looks really good already. Note that selecting the "first party" flag doesn't work, can you take another look? |
It works when removing spaces from the "first party" flag |
I have added "first_party" then removed the console logs and prints I had added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall, some minor change requests.
lgtm overall, can you do the following please to fix the remaining CI issues:
|
Do I sync my fork with the latest commits from main or do I push to origin main. I do not understand the first suggestion of updating branch with the latest commit to main. |
You sync your fork with the latest commit from main, you have done that successfully already what I can see 👍 |
Thank you @taylorhelene! This looks really good, I consider this as done! After the outreachy application phase we will take another look and see if we can merge this PR. |
Okay then. Thank you for the directions given. |
Thank you once again @taylorhelene ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this PR deleting an es
page?
/cc @svrnm @theletterf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wow. I missed that. Huge apologies!!
Also, note the following bug. I'm not sure if it was introduced by this PR or not: |
I have added a flag button on the search that adds flags like 'deprecated', 'native' and 'first party'. I have changed these thee components: